Add functionality to set the selected db item#1839
Merged
Conversation
charisk
force-pushed
the
charisk/set-selected-db-item
branch
from
ff74e4b to
3a6f95c
Compare
shati-patel
approved these changes
Dec 6, 2022
Contributor
shati-patel
left a comment
shati-patel
left a comment
There was a problem hiding this comment.
Looks good from my point of view! Annoying that the original test you wrote was flaky, but I'm happy for this to go in as-is. (Not sure how else to test 🤔 )
Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements functionality to allow setting the selected db item. This is not used yet - it will be used by the UI action.
Checklist
N/A:
ready-for-doc-reviewlabel there.